Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Migrate LatLngBounds to core implemenation #4796

Closed
tobrun opened this issue Apr 22, 2016 · 1 comment · Fixed by #8765
Closed

Migrate LatLngBounds to core implemenation #4796

tobrun opened this issue Apr 22, 2016 · 1 comment · Fixed by #8765
Assignees
@tobrun
Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers refactor
Milestone
android-v5.1.0

Comments

@tobrun
Copy link
Member

tobrun commented Apr 22, 2016 •
edited
Loading

The CameraBoundsUpdate is a Camera update method to move the camera position to a certain bounds. At this point for Android we calculate this in java here. In #4790 @1ec5 introduced iOS bindings in core to do these calculations. I feel we should migrate to the core implementation for having consistency and code reuse. Also this could fix issues with direction and at some point tilt.
@tobrun tobrun added refactor Android Mapbox Maps SDK for Android labels Apr 22, 2016
@tobrun
Copy link
Member Author

tobrun commented Jun 29, 2016

Adding a note here that CameraBoundsUpdate = newLatLngBounds

@cammace cammace mentioned this issue Aug 9, 2016
Closed
@tobrun tobrun changed the title Migrate CameraBoundsUpdate to core implemenation Migrate LatLngBounds to core implemenation Oct 20, 2016
@tobrun tobrun added the good first issue Good for newcomers label Oct 20, 2016
@tobrun tobrun mentioned this issue Oct 20, 2016
Closed
@cammace cammace mentioned this issue Nov 22, 2016
Closed
@tobrun tobrun mentioned this issue Apr 19, 2017
Merged
3 tasks
@tobrun tobrun added this to the android-v5.1.0 milestone Apr 19, 2017
@tobrun tobrun self-assigned this Apr 19, 2017
@tobrun tobrun mentioned this issue Apr 21, 2017
Merged
@tobrun tobrun mentioned this issue May 5, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android good first issue Good for newcomers refactor
Projects
None yet
Milestone
android-v5.1.0
Development

Successfully merging a pull request may close this issue.

move calculation of LatLngBounds to core mapbox/mapbox-gl-native
1 participant
@tobrun