You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Log.w(LOG_TAG, String.format("[HTTP] Request could not be executed: %s", e.getMessage()));
This doesn't make sense, for example, when the device is not connected to the network (offline mode) and the NoRouteToHostException is expected. Instead, I suggest we log according to the levels defined in the HTTPRequest class (CONNECTION_ERROR, TEMPORARY_ERROR, PERMANENT_ERROR). Something like:
if (type == PERMANENT_ERROR) {
Log.w(...);
} else if (type == TEMPORARY_ERROR) {
Log.i(...);
} else if (type == CONNECTION_ERROR) {
Log.d(...);
}
Thoughts @mapbox/android ?
The text was updated successfully, but these errors were encountered:
Currently, all failed OkHttp requests are logged as a warning:
This doesn't make sense, for example, when the device is not connected to the network (offline mode) and the
NoRouteToHostException
is expected. Instead, I suggest we log according to the levels defined in theHTTPRequest
class (CONNECTION_ERROR
,TEMPORARY_ERROR
,PERMANENT_ERROR
). Something like:Thoughts @mapbox/android ?
The text was updated successfully, but these errors were encountered: