Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Expose runtime style properties on PointAnnotations #6909

Closed
tobrun opened this issue Nov 4, 2016 · 3 comments
Closed

Expose runtime style properties on PointAnnotations #6909

tobrun opened this issue Nov 4, 2016 · 3 comments
Labels
annotations Annotations on iOS and macOS or markers on Android feature

Comments

@tobrun
Copy link
Member

tobrun commented Nov 4, 2016

With the upcoming mobile SDK releases, we're adding support for runtime styling. This adds capabilities as adding layers, sources and changing underlying properties dynamically. One thing that we haven't updated with these capabilities is our (point) annotations API.

Underneath the public API, our annotations API is using a SymbolLayer and a source with id com.mapbox.annotations. We should be able to leverage changing a couple of the symbol properties dynamically and expose some of them as an public API.

Some examples:

Exposing these properties will allow gl based annotations to be on par with view based annotations on terms of public API. For me, view annotations should be a lost resort solution when gl based markers don't fulfil the requirements. For every other case, users should use gl based markers instead.

cc @jfirebaugh @mapbox/mobile

@tobrun tobrun added feature annotations Annotations on iOS and macOS or markers on Android labels Nov 4, 2016
@tobrun
Copy link
Member Author

tobrun commented Nov 4, 2016

Since the possibilities are allmost endless what to support as a basic API,
I would try to have parity with Google Maps and expose the following for Android:

  • Alpha
  • Anchor
  • Flat or Billboard
  • Rotation
  • Position
  • Title
  • Snippet
  • Icon

@1ec5
Copy link
Contributor

1ec5 commented Nov 4, 2016

(#6172 would've been a related but more ambitious approach. #1734 would've been the same thing for iOS and macOS.)

@tobrun
Copy link
Member Author

tobrun commented Nov 7, 2016

Capturing from #1734 (comment) that this isn't a priority. Noting that this feature would allow us to support the same API as ViewMarkers ( we can advice to only use ViewMarkers for very limited cases) and it would allow us to have parity with Google Maps SDK. Closing for now.

@tobrun tobrun closed this as completed Dec 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android feature
Projects
None yet
Development

No branches or pull requests

2 participants