Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

clean up linear interpolation determination #79

Closed
incanus opened this issue Feb 21, 2014 · 0 comments
Closed

clean up linear interpolation determination #79

incanus opened this issue Feb 21, 2014 · 0 comments
Assignees

Comments

@incanus
Copy link
Contributor

incanus commented Feb 21, 2014

Over in #68 we brought in the new POI rendering, but the map->startRotating() etc. feels heavy-handed since:

  • We immediately call map->rotate() etc. for events like these.
  • There are timeouts, animations, and successive cancellations of each involved.

It feels like the Transform should know when it's rotating/panning/scaling and adjust sprite interpolation accordingly, without having to enter and exit these modes at the platform level.

For example, couldn't it check if active animations involving the angle/offset/scale are occurring presently and flip the switch then?

Thoughts @kkaefer?

@jfirebaugh jfirebaugh self-assigned this Apr 2, 2015
jfirebaugh added a commit that referenced this issue Apr 2, 2015
This brings the easing transition code a bit closer to how easings work
in gl-js. Instead of having an array of individual transitions for scale,
rotate, and pan, there is a single transition function that does all the
required calculations. This permits us to:

* Eliminate the "timeout" transition. (Fixes #126)
* Remove the start/stopPanning() and similar functions from the API. The
  transform is capable of determining when a transition that affects the
  pan position is in effect. (Fixes #79)
* Run style recalculations only when an ease transition that affects the
  zoom is in progress. (Fixes #1155)
mikemorris added a commit that referenced this issue Aug 21, 2015
add tests to new-arch branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants