This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix UTF-8 encoding, add missing package-info.java files #11261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
reviewed
Feb 20, 2018
| @@ -0,0 +1,4 @@ | |||
| /** | |||
| * Contains the Mapbox Maps Android egl API classes. | |||
There was a problem hiding this comment.
Looks like "EGL" is usually written in caps (e.g. https://www.khronos.org/egl), so we should probably do the same here?
ChrisLoer
approved these changes
Feb 20, 2018
not afaik, though when generating the docs it will produce an error and we are planning to validate this on CI as part of #9267. |
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11260
Closes #11088
cc @ChrisLoer