This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fix symbol flickering across antimeridian #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
approved these changes
May 18, 2018
| for (auto& zoomIndex : indexes) { | ||
| std::map<OverscaledTileID,TileLayerIndex> newZoomIndex; | ||
| for (auto& index : zoomIndex.second) { | ||
| // change the tileID's wrap and it to a new index |
There was a problem hiding this comment.
Nit: Looks like this should be something like "and move its index"?
|
Note: I had to restart the ios-sanitize and android-debug-arm-v7 tests to get them to pass, but it looked like it was just some sort of unrelated CI timeout. |
ansis
force-pushed
the
port-antimeridian-fix
branch
from
50c50e1
to
5c000fb
Compare
friedbunny
added
Core
|
Added the |
|
iOS changelog added in #12086. |
friedbunny
removed
the
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11878
This fixes:
I pushed the
glfw-appchanges I used to test the flickering to port-antimeridan-fix-debug@ChrisLoer