This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
StyleJson configuration on MapboxMapOptions #12664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
reviewed
Aug 21, 2018
| @@ -912,7 +935,7 @@ public void writeToParcel(Parcel dest, int flags) { | |||
| dest.writeByte((byte) (zoomGesturesEnabled ? 1 : 0)); | |||
| dest.writeByte((byte) (doubleTapGesturesEnabled ? 1 : 0)); | |||
|
|
|||
| dest.writeString(style); | |||
| dest.writeString(styleUrl); | |||
| dest.writeString(apiBaseUrl); | |||
There was a problem hiding this comment.
We are missing writing the styleJson to the parcel.
There was a problem hiding this comment.
nice catch 😅 fixed in fe04abb
…apView attributes
tobrun
force-pushed
the
tvn-style-json-mapboxmap-options
branch
from
c3340c1
to
fe04abb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a styleJson configuration MapboxMapOptions and MapView attributes.
This is usefull for when a user wants to package an their style json in their app.