This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix OnMapReady delivery when a new style is requested before the map is initialized #13203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-fix-style-loading-before-map-initialized
branch
from
c86154d
to
13c9956
Compare
tobrun
approved these changes
Oct 26, 2018
…s requested before the map is initialized
LukasPaczos
force-pushed
the
lp-fix-style-loading-before-map-initialized
branch
from
13c9956
to
7d41c34
Compare
This was referenced Oct 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small regression introduced by the #13133 - when requesting a new style before the drawing surface is initialized, before, we were relying on
NativeMapViewbeing created after the view hierarchy is established, which means, that calls likemapView#setStyleUrldone in the#onCreatewould add the style to theMapboxMapOptions, becauseNativeMapViewwas stillnull. Now, we are initializing theNativeMapViewimmediately, which means that callingmapView#setStyleUrlwould start loading the style instantly introducing a race condition - we would either create the drawing surface before the style is loaded, then the execution continued as expected, or the style would've loaded first, resulting in not deliveringOnMapReadyat all.The other part of this PR removes the usage of the deprecated
OnMapChangelistener across the project.