Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] remove unused dem memory #13550

Merged
merged 4 commits into from
Mar 5, 2019
Merged

[core] remove unused dem memory #13550

merged 4 commits into from
Mar 5, 2019

Conversation

mollymerp
Copy link
Contributor

port of mapbox/mapbox-gl-js#7683 – this needs gl-js submodule update for shader changes once it merges

@mollymerp mollymerp added GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl labels Dec 12, 2018
@mollymerp
Copy link
Contributor Author

mollymerp commented Dec 12, 2018

this is blocked by the port of the sort-by-key property now because I need to update the gl-js submodule for the shaders

cc @ansis

@stale stale bot added the archived Archived because of inactivity label Feb 10, 2019
@stale
Copy link

stale bot commented Feb 10, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Feb 10, 2019
@stale stale bot removed the archived Archived because of inactivity label Feb 19, 2019
@pozdnyakov pozdnyakov self-assigned this Mar 4, 2019
@@ -1,3 +1,6 @@
var spec = module.exports = require('../mapbox-gl-js/src/style-spec/reference/v8');

// Make temporary modifications here when Native doesn't have all features that JS has.
delete spec.layout_symbol['symbol-sort-key'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe worth creating backporting issue for gl-native.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pozdnyakov pozdnyakov merged commit be2a4a0 into master Mar 5, 2019
@pozdnyakov pozdnyakov deleted the optimize-dem-tex branch March 5, 2019 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants