This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollymerp
added
GL JS parity
For feature parity with Mapbox GL JS
Core
The cross-platform C++ core, aka mbgl
labels
Dec 12, 2018
4 tasks
this is blocked by the port of the cc @ansis |
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
pozdnyakov
force-pushed
the
optimize-dem-tex
branch
from
March 4, 2019 20:39
92ec974
to
602c377
Compare
mourner
approved these changes
Mar 5, 2019
alexshalamov
approved these changes
Mar 5, 2019
@@ -1,3 +1,6 @@ | |||
var spec = module.exports = require('../mapbox-gl-js/src/style-spec/reference/v8'); | |||
|
|||
// Make temporary modifications here when Native doesn't have all features that JS has. | |||
delete spec.layout_symbol['symbol-sort-key']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe worth creating backporting issue for gl-native.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of mapbox/mapbox-gl-js#7683 – this needs gl-js submodule update for shader changes once it merges