This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] SymbolBucket: use single map for paint properties data #13724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviates unnecessary lookups, improves readability.
ChrisLoer
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
👍 Looks good to me, although I don't know what's up with the Android test failure. Looks like the failure is in testCollatorExpression in the Android ExpressionTest.... which seems totally unrelated. I haven't seen that failure before and we should keep an eye on it, but for now I'd just try re-running the test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviates unnecessary lookups, improves readability.