[Android]Add MapEventFactory

[Chaoba]

Remove map event creation code from the mapbox-events-android library and add it to map sdk.
Waiting for new version of telemetry sdk after this PR is merged.

[tobrun]

Sorry for requesting the following changes. I'm aware that you are just migrating the code from mapbox-events to here but this is the ideal opportunity for us to enforce code convention/cohension. Would you be able to pick this up @Chaoba ? I requested only changes to MapClickEvent but they are applicable to all MapEvent derived classes.

Next to those changes, can we also add some tests validating the contents of the event?

[Chaoba]

@tobrun Thanks for your advise, you are right, let's take this opportunity to make it best.

[tobrun]

Made some comments on OfflineDownloadEndEvent but they are applicable to other events as well. Really like the new state model objects to avoid duplication.

If the comment about the parceable interface is correct and we don't need it . Maybe we can introduce a base class that extends Event and we can hide the empty parceable implementation? We could also move or enforce other shared items as: PhoneState and event.

Thank you for adding tests! One thing useful to test for is to see of the model classes are getting correctly serialized with Gson. So if we convert from and back with Gson we should have the same object. (to make this work, we will have to start adding equals/hashcode and a toString to all our events).

[Chaoba]

If the comment about the parceable interface is correct and we don't need it . Maybe we can introduce a base class that extends Event and we can hide the empty parceable implementation? We could also move or enforce other shared items as: PhoneState and event.

When this PR is merged, we can remove this empty implementation.

[tobrun]

If the comment about the parceable interface is correct and we don't need it . Maybe we can introduce a base class that extends Event and we can hide the empty parceable implementation? We could also move or enforce other shared items as: PhoneState and event.

When this PR is merged, we can remove this empty implementation.

Lets include those changes as well in this PR, any eta on merging that?

[Chaoba]

Lets include those changes as well in this PR, any eta on merging that?

@andrlee Could you review and merge this PR? It seems we are blocked by it.

[andrlee]

hey @Chaoba i'd like to avoid making changes to the public signatures of Event class and i don't believe that you should be blocked by it. i'd suggest to add a child class with default implementation to this PR.

[tobrun]

Looks good, , two minor nit comments

[tobrun]

@Chaoba the CI build is failing because we need to update the mapbox-events submodule in https://github.com/mapbox/mapbox-gl-native/tree/master/platform/android/vendor. LMK if you have any questions on how to do that.

[tobrun]

4.4.1 of telemetry was released, can we integrate that in this PR? https://github.com/mapbox/mapbox-events-android/releases/tag/telem-4.4.1-core-1.3.0

[tobrun]

Can we expand SchemaTest.java to support all events we have in https://github.com/mapbox/mapbox-gl-native/tree/37d17dc2b986c587f06499265f34b49b8bc78f6f/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/module/telemetry, not all are being tested atm.

[LukasPaczos]

I'm going to go ahead and merge. Remaining work ticketed in #14459.