From 91cb0444d9dfd04216d686e6b7f0234fa8b6726a Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Wed, 27 Nov 2019 23:33:49 +0200 Subject: [PATCH 1/4] [metrics] Isolate binary size metrics Will give us a better view of what changed and by how much. Otherwise the test stops at the first failure. --- .../expected.png | Bin .../android-arm64-v8a/metrics.json | 9 ++++ .../binary-size/android-arm64-v8a/style.json | 22 ++++++++ .../expected.png | Bin .../android-armeabi-v7a/metrics.json | 9 ++++ .../android-armeabi-v7a/style.json | 22 ++++++++ .../binary-size/android-x86/expected.png | Bin 0 -> 225 bytes .../binary-size/android-x86/metrics.json | 9 ++++ .../tests/binary-size/android-x86/style.json | 22 ++++++++ .../binary-size/android-x86_64/expected.png | Bin 0 -> 225 bytes .../binary-size/android-x86_64/metrics.json | 9 ++++ .../style.json | 3 -- .../binary-size/linux-clang8/expected.png | Bin 0 -> 225 bytes .../binary-size/linux-clang8/metrics.json | 19 +++++++ .../tests/binary-size/linux-clang8/style.json | 24 +++++++++ .../tests/binary-size/linux-gcc8/expected.png | Bin 0 -> 225 bytes .../tests/binary-size/linux-gcc8/metrics.json | 19 +++++++ .../tests/binary-size/linux-gcc8/style.json | 24 +++++++++ .../binary-size/macos-xcode11/expected.png | Bin 0 -> 225 bytes .../binary-size/macos-xcode11/metrics.json | 19 +++++++ .../binary-size/macos-xcode11/style.json | 24 +++++++++ .../binary-size/shared-library/metrics.json | 24 --------- metrics/tests/binary-size/tools/metrics.json | 49 ------------------ metrics/tests/binary-size/tools/style.json | 30 ----------- 24 files changed, 231 insertions(+), 106 deletions(-) rename metrics/tests/binary-size/{shared-library => android-arm64-v8a}/expected.png (100%) create mode 100644 metrics/tests/binary-size/android-arm64-v8a/metrics.json create mode 100644 metrics/tests/binary-size/android-arm64-v8a/style.json rename metrics/tests/binary-size/{tools => android-armeabi-v7a}/expected.png (100%) create mode 100644 metrics/tests/binary-size/android-armeabi-v7a/metrics.json create mode 100644 metrics/tests/binary-size/android-armeabi-v7a/style.json create mode 100644 metrics/tests/binary-size/android-x86/expected.png create mode 100644 metrics/tests/binary-size/android-x86/metrics.json create mode 100644 metrics/tests/binary-size/android-x86/style.json create mode 100644 metrics/tests/binary-size/android-x86_64/expected.png create mode 100644 metrics/tests/binary-size/android-x86_64/metrics.json rename metrics/tests/binary-size/{shared-library => android-x86_64}/style.json (52%) create mode 100644 metrics/tests/binary-size/linux-clang8/expected.png create mode 100644 metrics/tests/binary-size/linux-clang8/metrics.json create mode 100644 metrics/tests/binary-size/linux-clang8/style.json create mode 100644 metrics/tests/binary-size/linux-gcc8/expected.png create mode 100644 metrics/tests/binary-size/linux-gcc8/metrics.json create mode 100644 metrics/tests/binary-size/linux-gcc8/style.json create mode 100644 metrics/tests/binary-size/macos-xcode11/expected.png create mode 100644 metrics/tests/binary-size/macos-xcode11/metrics.json create mode 100644 metrics/tests/binary-size/macos-xcode11/style.json delete mode 100644 metrics/tests/binary-size/shared-library/metrics.json delete mode 100644 metrics/tests/binary-size/tools/metrics.json delete mode 100644 metrics/tests/binary-size/tools/style.json diff --git a/metrics/tests/binary-size/shared-library/expected.png b/metrics/tests/binary-size/android-arm64-v8a/expected.png similarity index 100% rename from metrics/tests/binary-size/shared-library/expected.png rename to metrics/tests/binary-size/android-arm64-v8a/expected.png diff --git a/metrics/tests/binary-size/android-arm64-v8a/metrics.json b/metrics/tests/binary-size/android-arm64-v8a/metrics.json new file mode 100644 index 00000000000..df5bfedd788 --- /dev/null +++ b/metrics/tests/binary-size/android-arm64-v8a/metrics.json @@ -0,0 +1,9 @@ +{ + "file-size": [ + [ + "android-arm64-v8a", + "/src/workspace/next-android-arm64-v8a-release/lib/libmapbox-gl.so", + 6496584 + ] + ] +} diff --git a/metrics/tests/binary-size/android-arm64-v8a/style.json b/metrics/tests/binary-size/android-arm64-v8a/style.json new file mode 100644 index 00000000000..e03001ffef3 --- /dev/null +++ b/metrics/tests/binary-size/android-arm64-v8a/style.json @@ -0,0 +1,22 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "android-arm64-v8a", "/src/workspace/next-android-arm64-v8a-release/lib/libmapbox-gl.so", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/tools/expected.png b/metrics/tests/binary-size/android-armeabi-v7a/expected.png similarity index 100% rename from metrics/tests/binary-size/tools/expected.png rename to metrics/tests/binary-size/android-armeabi-v7a/expected.png diff --git a/metrics/tests/binary-size/android-armeabi-v7a/metrics.json b/metrics/tests/binary-size/android-armeabi-v7a/metrics.json new file mode 100644 index 00000000000..5969b3e8dfc --- /dev/null +++ b/metrics/tests/binary-size/android-armeabi-v7a/metrics.json @@ -0,0 +1,9 @@ +{ + "file-size": [ + [ + "android-armeabi-v7a", + "/src/workspace/next-android-armeabi-v7a-release/lib/libmapbox-gl.so", + 3072756 + ] + ] +} diff --git a/metrics/tests/binary-size/android-armeabi-v7a/style.json b/metrics/tests/binary-size/android-armeabi-v7a/style.json new file mode 100644 index 00000000000..78ec439e5e0 --- /dev/null +++ b/metrics/tests/binary-size/android-armeabi-v7a/style.json @@ -0,0 +1,22 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "android-armeabi-v7a", "/src/workspace/next-android-armeabi-v7a-release/lib/libmapbox-gl.so", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/android-x86/expected.png b/metrics/tests/binary-size/android-x86/expected.png new file mode 100644 index 0000000000000000000000000000000000000000..63740e7305f738fbf9a84a350522e24b3895f2ae GIT binary patch literal 225 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=D?D8sLn`JxJ-3jNfq~<|g1PUW uSFs&*SiY>bm)%6}LWRR)#=*c~u+EtIF>1DE++(1d89ZJ6T-G@yGywozKuw?k literal 0 HcmV?d00001 diff --git a/metrics/tests/binary-size/android-x86/metrics.json b/metrics/tests/binary-size/android-x86/metrics.json new file mode 100644 index 00000000000..70b07959af4 --- /dev/null +++ b/metrics/tests/binary-size/android-x86/metrics.json @@ -0,0 +1,9 @@ +{ + "file-size": [ + [ + "android-x86", + "/src/workspace/next-android-x86-release/lib/libmapbox-gl.so", + 6988568 + ] + ] +} diff --git a/metrics/tests/binary-size/android-x86/style.json b/metrics/tests/binary-size/android-x86/style.json new file mode 100644 index 00000000000..0db28e9803e --- /dev/null +++ b/metrics/tests/binary-size/android-x86/style.json @@ -0,0 +1,22 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "android-x86", "/src/workspace/next-android-x86-release/lib/libmapbox-gl.so", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/android-x86_64/expected.png b/metrics/tests/binary-size/android-x86_64/expected.png new file mode 100644 index 0000000000000000000000000000000000000000..63740e7305f738fbf9a84a350522e24b3895f2ae GIT binary patch literal 225 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=D?D8sLn`JxJ-3jNfq~<|g1PUW uSFs&*SiY>bm)%6}LWRR)#=*c~u+EtIF>1DE++(1d89ZJ6T-G@yGywozKuw?k literal 0 HcmV?d00001 diff --git a/metrics/tests/binary-size/android-x86_64/metrics.json b/metrics/tests/binary-size/android-x86_64/metrics.json new file mode 100644 index 00000000000..9e39b5a3d58 --- /dev/null +++ b/metrics/tests/binary-size/android-x86_64/metrics.json @@ -0,0 +1,9 @@ +{ + "file-size": [ + [ + "android-x86_64", + "/src/workspace/next-android-x86_64-release/lib/libmapbox-gl.so", + 7106920 + ] + ] +} diff --git a/metrics/tests/binary-size/shared-library/style.json b/metrics/tests/binary-size/android-x86_64/style.json similarity index 52% rename from metrics/tests/binary-size/shared-library/style.json rename to metrics/tests/binary-size/android-x86_64/style.json index aecc114165d..0d60c63a7a0 100644 --- a/metrics/tests/binary-size/shared-library/style.json +++ b/metrics/tests/binary-size/android-x86_64/style.json @@ -3,9 +3,6 @@ "metadata": { "test": { "operations": [ - ["probeFileSize", "android-arm64-v8a", "/src/workspace/next-android-arm64-v8a-release/lib/libmapbox-gl.so", 0.01], - ["probeFileSize", "android-armeabi-v7a", "/src/workspace/next-android-armeabi-v7a-release/lib/libmapbox-gl.so", 0.01], - ["probeFileSize", "android-x86-release", "/src/workspace/next-android-x86-release/lib/libmapbox-gl.so", 0.01], ["probeFileSize", "android-x86_64", "/src/workspace/next-android-x86_64-release/lib/libmapbox-gl.so", 0.01] ], "width": 64, diff --git a/metrics/tests/binary-size/linux-clang8/expected.png b/metrics/tests/binary-size/linux-clang8/expected.png new file mode 100644 index 0000000000000000000000000000000000000000..63740e7305f738fbf9a84a350522e24b3895f2ae GIT binary patch literal 225 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=D?D8sLn`JxJ-3jNfq~<|g1PUW uSFs&*SiY>bm)%6}LWRR)#=*c~u+EtIF>1DE++(1d89ZJ6T-G@yGywozKuw?k literal 0 HcmV?d00001 diff --git a/metrics/tests/binary-size/linux-clang8/metrics.json b/metrics/tests/binary-size/linux-clang8/metrics.json new file mode 100644 index 00000000000..7af3f79ea6d --- /dev/null +++ b/metrics/tests/binary-size/linux-clang8/metrics.json @@ -0,0 +1,19 @@ +{ + "file-size": [ + [ + "mbgl-glfw", + "/src/workspace/next-linux-clang8-release/bin/mbgl-glfw", + 6225032 + ], + [ + "mbgl-offline", + "/src/workspace/next-linux-clang8-release/bin/mbgl-offline", + 5532376 + ], + [ + "mbgl-render", + "/src/workspace/next-linux-clang8-release/bin/mbgl-render", + 6151096 + ] + ] +} diff --git a/metrics/tests/binary-size/linux-clang8/style.json b/metrics/tests/binary-size/linux-clang8/style.json new file mode 100644 index 00000000000..7af68d53597 --- /dev/null +++ b/metrics/tests/binary-size/linux-clang8/style.json @@ -0,0 +1,24 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "mbgl-glfw", "/src/workspace/next-linux-clang8-release/bin/mbgl-glfw", 0.01], + ["probeFileSize", "mbgl-offline", "/src/workspace/next-linux-clang8-release/bin/mbgl-offline", 0.01], + ["probeFileSize", "mbgl-render", "/src/workspace/next-linux-clang8-release/bin/mbgl-render", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/linux-gcc8/expected.png b/metrics/tests/binary-size/linux-gcc8/expected.png new file mode 100644 index 0000000000000000000000000000000000000000..63740e7305f738fbf9a84a350522e24b3895f2ae GIT binary patch literal 225 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=D?D8sLn`JxJ-3jNfq~<|g1PUW uSFs&*SiY>bm)%6}LWRR)#=*c~u+EtIF>1DE++(1d89ZJ6T-G@yGywozKuw?k literal 0 HcmV?d00001 diff --git a/metrics/tests/binary-size/linux-gcc8/metrics.json b/metrics/tests/binary-size/linux-gcc8/metrics.json new file mode 100644 index 00000000000..4a1e61f0688 --- /dev/null +++ b/metrics/tests/binary-size/linux-gcc8/metrics.json @@ -0,0 +1,19 @@ +{ + "file-size": [ + [ + "mbgl-glfw", + "/src/workspace/next-linux-gcc8-release/bin/mbgl-glfw", + 7205192 + ], + [ + "mbgl-offline", + "/src/workspace/next-linux-gcc8-release/bin/mbgl-offline", + 6357224 + ], + [ + "mbgl-render", + "/src/workspace/next-linux-gcc8-release/bin/mbgl-render", + 7143752 + ] + ] +} diff --git a/metrics/tests/binary-size/linux-gcc8/style.json b/metrics/tests/binary-size/linux-gcc8/style.json new file mode 100644 index 00000000000..8ace1f82aba --- /dev/null +++ b/metrics/tests/binary-size/linux-gcc8/style.json @@ -0,0 +1,24 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "mbgl-glfw", "/src/workspace/next-linux-gcc8-release/bin/mbgl-glfw", 0.01], + ["probeFileSize", "mbgl-offline", "/src/workspace/next-linux-gcc8-release/bin/mbgl-offline", 0.01], + ["probeFileSize", "mbgl-render", "/src/workspace/next-linux-gcc8-release/bin/mbgl-render", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/macos-xcode11/expected.png b/metrics/tests/binary-size/macos-xcode11/expected.png new file mode 100644 index 0000000000000000000000000000000000000000..63740e7305f738fbf9a84a350522e24b3895f2ae GIT binary patch literal 225 zcmeAS@N?(olHy`uVBq!ia0vp^4j|0I1|(Ny7TyC=D?D8sLn`JxJ-3jNfq~<|g1PUW uSFs&*SiY>bm)%6}LWRR)#=*c~u+EtIF>1DE++(1d89ZJ6T-G@yGywozKuw?k literal 0 HcmV?d00001 diff --git a/metrics/tests/binary-size/macos-xcode11/metrics.json b/metrics/tests/binary-size/macos-xcode11/metrics.json new file mode 100644 index 00000000000..9a4ffebd13b --- /dev/null +++ b/metrics/tests/binary-size/macos-xcode11/metrics.json @@ -0,0 +1,19 @@ +{ + "file-size": [ + [ + "mbgl-glfw", + "/src/workspace/next-macos-xcode11-release/bin/mbgl-glfw", + 5439932 + ], + [ + "mbgl-offline", + "/src/workspace/next-macos-xcode11-release/bin/mbgl-offline", + 5334136 + ], + [ + "mbgl-render", + "/src/workspace/next-macos-xcode11-release/bin/mbgl-render", + 5384420 + ] + ] +} diff --git a/metrics/tests/binary-size/macos-xcode11/style.json b/metrics/tests/binary-size/macos-xcode11/style.json new file mode 100644 index 00000000000..1c2e8123f9a --- /dev/null +++ b/metrics/tests/binary-size/macos-xcode11/style.json @@ -0,0 +1,24 @@ +{ + "version": 8, + "metadata": { + "test": { + "operations": [ + ["probeFileSize", "mbgl-glfw", "/src/workspace/next-macos-xcode11-release/bin/mbgl-glfw", 0.01], + ["probeFileSize", "mbgl-offline", "/src/workspace/next-macos-xcode11-release/bin/mbgl-offline", 0.01], + ["probeFileSize", "mbgl-render", "/src/workspace/next-macos-xcode11-release/bin/mbgl-render", 0.01] + ], + "width": 64, + "height": 64 + } + }, + "sources": {}, + "layers": [ + { + "id": "background", + "type": "background", + "paint": { + "background-color": "green" + } + } + ] +} diff --git a/metrics/tests/binary-size/shared-library/metrics.json b/metrics/tests/binary-size/shared-library/metrics.json deleted file mode 100644 index 4501fd0f4ab..00000000000 --- a/metrics/tests/binary-size/shared-library/metrics.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "file-size": [ - [ - "android-arm64-v8a", - "/src/workspace/next-android-arm64-v8a-release/lib/libmapbox-gl.so", - 6496584 - ], - [ - "android-armeabi-v7a", - "/src/workspace/next-android-armeabi-v7a-release/lib/libmapbox-gl.so", - 3072756 - ], - [ - "android-x86-release", - "/src/workspace/next-android-x86-release/lib/libmapbox-gl.so", - 6988568 - ], - [ - "android-x86_64", - "/src/workspace/next-android-x86_64-release/lib/libmapbox-gl.so", - 7106920 - ] - ] -} \ No newline at end of file diff --git a/metrics/tests/binary-size/tools/metrics.json b/metrics/tests/binary-size/tools/metrics.json deleted file mode 100644 index 457db1c4dce..00000000000 --- a/metrics/tests/binary-size/tools/metrics.json +++ /dev/null @@ -1,49 +0,0 @@ -{ - "file-size": [ - [ - "linux-clang8-mbgl-glfw", - "/src/workspace/next-linux-clang8-release/bin/mbgl-glfw", - 6225032 - ], - [ - "linux-clang8-mbgl-offline", - "/src/workspace/next-linux-clang8-release/bin/mbgl-offline", - 5532376 - ], - [ - "linux-clang8-mbgl-render", - "/src/workspace/next-linux-clang8-release/bin/mbgl-render", - 6151096 - ], - [ - "linux-gcc8-mbgl-glfw", - "/src/workspace/next-linux-gcc8-release/bin/mbgl-glfw", - 7205192 - ], - [ - "linux-gcc8-mbgl-offline", - "/src/workspace/next-linux-gcc8-release/bin/mbgl-offline", - 6357224 - ], - [ - "linux-gcc8-mbgl-render", - "/src/workspace/next-linux-gcc8-release/bin/mbgl-render", - 7143752 - ], - [ - "macos-xcode11-mbgl-glfw", - "/src/workspace/next-macos-xcode11-release/bin/mbgl-glfw", - 5439932 - ], - [ - "macos-xcode11-mbgl-offline", - "/src/workspace/next-macos-xcode11-release/bin/mbgl-offline", - 5334136 - ], - [ - "macos-xcode11-mbgl-render", - "/src/workspace/next-macos-xcode11-release/bin/mbgl-render", - 5384420 - ] - ] -} \ No newline at end of file diff --git a/metrics/tests/binary-size/tools/style.json b/metrics/tests/binary-size/tools/style.json deleted file mode 100644 index c1af092bc5c..00000000000 --- a/metrics/tests/binary-size/tools/style.json +++ /dev/null @@ -1,30 +0,0 @@ -{ - "version": 8, - "metadata": { - "test": { - "operations": [ - ["probeFileSize", "linux-clang8-mbgl-glfw", "/src/workspace/next-linux-clang8-release/bin/mbgl-glfw", 0.01], - ["probeFileSize", "linux-clang8-mbgl-offline", "/src/workspace/next-linux-clang8-release/bin/mbgl-offline", 0.01], - ["probeFileSize", "linux-clang8-mbgl-render", "/src/workspace/next-linux-clang8-release/bin/mbgl-render", 0.01], - ["probeFileSize", "linux-gcc8-mbgl-glfw", "/src/workspace/next-linux-gcc8-release/bin/mbgl-glfw", 0.01], - ["probeFileSize", "linux-gcc8-mbgl-offline", "/src/workspace/next-linux-gcc8-release/bin/mbgl-offline", 0.01], - ["probeFileSize", "linux-gcc8-mbgl-render", "/src/workspace/next-linux-gcc8-release/bin/mbgl-render", 0.01], - ["probeFileSize", "macos-xcode11-mbgl-glfw", "/src/workspace/next-macos-xcode11-release/bin/mbgl-glfw", 0.01], - ["probeFileSize", "macos-xcode11-mbgl-offline", "/src/workspace/next-macos-xcode11-release/bin/mbgl-offline", 0.01], - ["probeFileSize", "macos-xcode11-mbgl-render", "/src/workspace/next-macos-xcode11-release/bin/mbgl-render", 0.01] - ], - "width": 64, - "height": 64 - } - }, - "sources": {}, - "layers": [ - { - "id": "background", - "type": "background", - "paint": { - "background-color": "green" - } - } - ] -} From 2bd269296155647a9c92e3c4b6ffc1872f71b3d5 Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Wed, 27 Nov 2019 23:44:58 +0200 Subject: [PATCH 2/4] [metrics] Make the parsing of metrics even more strict File must be `metrics.json`. --- render-test/parser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/render-test/parser.cpp b/render-test/parser.cpp index 093d4b37f92..1c1f8b27988 100644 --- a/render-test/parser.cpp +++ b/render-test/parser.cpp @@ -294,7 +294,7 @@ std::vector readExpectedImageEntries(const mbgl::filesystem::path& } std::vector readExpectedMetricEntries(const mbgl::filesystem::path& base) { - static const std::regex regex(".*/metrics.*.json"); + static const std::regex regex(".*/metrics.json"); return readExpectedEntries(regex, base); } From ebeeacf781e2728c81d9f722b9ef4b664949c8a8 Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Wed, 27 Nov 2019 18:47:22 +0200 Subject: [PATCH 3/4] [android] Use -Oz to reduce binary size --- next/platform/android/android.cmake | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/next/platform/android/android.cmake b/next/platform/android/android.cmake index b0c9c712dcc..628a25515a5 100644 --- a/next/platform/android/android.cmake +++ b/next/platform/android/android.cmake @@ -387,11 +387,11 @@ set_target_properties(mbgl-benchmark-runner PROPERTIES LINK_FLAGS_RELEASE "-fuse set_target_properties(mbgl-render-test-runner PROPERTIES LINK_FLAGS_RELEASE "-fuse-ld=gold -O2 -flto -Wl,--icf=safe") set_target_properties(mbgl-test-runner PROPERTIES LINK_FLAGS_RELEASE "-fuse-ld=gold -O2 -flto -Wl,--icf=safe") -target_compile_options(example-custom-layer PRIVATE $<$:-Qunused-arguments -flto>) -target_compile_options(mapbox-gl PRIVATE $<$:-Qunused-arguments -flto>) -target_compile_options(mbgl-core PRIVATE $<$:-Qunused-arguments -flto>) -target_compile_options(mbgl-render-test-runner PRIVATE $<$:-Qunused-arguments -flto>) -target_compile_options(mbgl-vendor-icu PRIVATE $<$:-Qunused-arguments -flto>) -target_compile_options(mbgl-vendor-sqlite PRIVATE $<$:-Qunused-arguments -flto>) +target_compile_options(example-custom-layer PRIVATE $<$:-Oz -Qunused-arguments -flto>) +target_compile_options(mapbox-gl PRIVATE $<$:-Oz -Qunused-arguments -flto>) +target_compile_options(mbgl-core PRIVATE $<$:-Oz -Qunused-arguments -flto>) +target_compile_options(mbgl-render-test-runner PRIVATE $<$:-Oz -Qunused-arguments -flto>) +target_compile_options(mbgl-vendor-icu PRIVATE $<$:-Oz -Qunused-arguments -flto>) +target_compile_options(mbgl-vendor-sqlite PRIVATE $<$:-Oz -Qunused-arguments -flto>) install(TARGETS mapbox-gl LIBRARY DESTINATION lib) From dfcf47bcc7860ed1726b084390a41253b1fdda6f Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Thu, 28 Nov 2019 11:31:32 +0200 Subject: [PATCH 4/4] [metrics] Add new baselines. --- metrics/tests/binary-size/android-arm64-v8a/metrics.json | 2 +- metrics/tests/binary-size/android-x86/metrics.json | 2 +- metrics/tests/binary-size/android-x86_64/metrics.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/metrics/tests/binary-size/android-arm64-v8a/metrics.json b/metrics/tests/binary-size/android-arm64-v8a/metrics.json index df5bfedd788..740fe86d019 100644 --- a/metrics/tests/binary-size/android-arm64-v8a/metrics.json +++ b/metrics/tests/binary-size/android-arm64-v8a/metrics.json @@ -3,7 +3,7 @@ [ "android-arm64-v8a", "/src/workspace/next-android-arm64-v8a-release/lib/libmapbox-gl.so", - 6496584 + 4596040 ] ] } diff --git a/metrics/tests/binary-size/android-x86/metrics.json b/metrics/tests/binary-size/android-x86/metrics.json index 70b07959af4..1d0d85ff3c4 100644 --- a/metrics/tests/binary-size/android-x86/metrics.json +++ b/metrics/tests/binary-size/android-x86/metrics.json @@ -3,7 +3,7 @@ [ "android-x86", "/src/workspace/next-android-x86-release/lib/libmapbox-gl.so", - 6988568 + 4625176 ] ] } diff --git a/metrics/tests/binary-size/android-x86_64/metrics.json b/metrics/tests/binary-size/android-x86_64/metrics.json index 9e39b5a3d58..98147d8b842 100644 --- a/metrics/tests/binary-size/android-x86_64/metrics.json +++ b/metrics/tests/binary-size/android-x86_64/metrics.json @@ -3,7 +3,7 @@ [ "android-x86_64", "/src/workspace/next-android-x86_64-release/lib/libmapbox-gl.so", - 7106920 + 4874600 ] ] }