Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

expose annotation styling #1820

Closed
wants to merge 4 commits into from
Closed

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Jul 2, 2015

Fixes #1734 and allows a workaround for #1814 by exposing the full set of line & fill layout and paint properties to map clients.

Todo:

  • Safely query what's set in the passed style (i.e. no .at() directly).
  • Render more values.
  • Set sane defaults in core for the properties (not necessarily the same as the defaults in LineProperties/FillProperties; for example, shapes shouldn't be black or default to miter line join).
  • Test dead code removal from 174fb6b.
  • Find a better way to determine fill/line distinction now that the use of the StyleProperties variant is gone (i.e. not this).

@incanus incanus added feature refactor ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Jul 2, 2015
@incanus incanus self-assigned this Jul 2, 2015
@incanus incanus added this to the iOS Beta 3 milestone Jul 2, 2015
@jfirebaugh
Copy link
Contributor

Is there a dependency chain pulling in class_properties.hpp and property_transition.hpp? Those looks like they might be unnecessary. I'm ok with the other includes being "semi-public", in that they are used by iOS but not considered part of the public core GL. These interfaces will probably change a lot with mutable style API and data driven styles.

@incanus incanus removed this from the iOS Beta 3 milestone Jul 6, 2015
@jfirebaugh
Copy link
Contributor

@incanus What's the status of this PR?

@jfirebaugh
Copy link
Contributor

Going in the direction of #837 instead.

@jfirebaugh jfirebaugh closed this Oct 29, 2015
@jfirebaugh jfirebaugh deleted the 1734-expose-annotation-styling branch October 29, 2015 22:38
@incanus
Copy link
Contributor Author

incanus commented Nov 4, 2015

👍

@1ec5 1ec5 removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants