text-pitch-alignment #5288
text-pitch-alignment #5288
Conversation
| @@ -48,7 +48,7 @@ void Painter::renderSDF(SymbolBucket &bucket, | |||
| bool alignedWithMap = rotationAlignment == RotationAlignmentType::Map; | |||
| float gammaScale = 1.0f; | |||
|
|
|||
| if (alignedWithMap) { | |||
| if (false && alignedWithMap) { | |||
There was a problem hiding this comment.
I'll fix this, was poking but this whole codepath can be dropped.
1ec5
added
feature
navigation
|
Good stuff @yhahn! Do you know if this affects the recently added
|
yhahn
force-pushed
the
unskew
branch
4 times, most recently
from
7ec107d
to
e91dba9
Compare
… inheritance for this value from text-rotation-alignment
yhahn
force-pushed
the
unskew
branch
2 times, most recently
from
0f13843
to
756d83b
Compare
yhahn
changed the title
|
@jfirebaugh 🙏 ready for your review when you have a chance : ) |
| @@ -6,12 +6,14 @@ const spec = require('mapbox-gl-style-spec').latest; | |||
| var parseCSSColor = require('csscolorparser').parseCSSColor; | |||
|
|
|||
| global.camelize = function (str) { | |||
| str = str === undefined ? 'undefined' : str; | |||
There was a problem hiding this comment.
What prompted this change, and the corresponding one in camelizeWithLeadingLowercase?
There was a problem hiding this comment.
This was to have Undefined be the value for text-pitch-alignment when it's not defined in the style and be able to detect when inheritance should kick in (per mapbox/mapbox-gl-style-spec#460 (comment)).
It's definitely the main eyebrow-raiser in this PR 😄 would love to know if there's a better way to achieve this.
There was a problem hiding this comment.
Yeah, I see the AlignmentType::Undefined value. Why does a JS undefined value pass through camelize though?
|
👌 |
Native port of mapbox/mapbox-gl-js#2668.
Backlog
cc @lucaswoj @jfirebaugh @mollymerp @lxbarth