This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Adjust logging level for failed OkHttp requests #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zugaldia, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @bleege and @tmpsantos to be potential reviewers. |
|
The code LGTM 👍 . However I'm seeing Bitrise iOS and Travis CI failing for whatever reason. I'm going to try restarting the builds to officially get the 👍 before we merge. |
|
Bitrise on iOS is now happy. Waiting on Travis. |
|
Travis is now a happy camper. Next stop: mergetown! |
|
@bleege Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
LoginMapboxAccountManager(whenisConnectedis false an exception is thrown and logged separately)./cc: @bleege for review.
Fixes #6356.