This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivovandongen
suggested changes
Mar 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should take into consideration that there can be multiple (non-overlapping) holes.
For reference, #7397 attempted to support multiple holes at the Java level, and mbgl does support multiple holes (as seen on iOS and macOS); it’s the JNI part that apparently wasn’t working. |
Guardiola31337
force-pushed
the
pg-7397-android-polygon-hole
branch
from
April 9, 2017 13:29
e965a88
to
a5b986b
Compare
Guardiola31337
force-pushed
the
pg-7397-android-polygon-hole
branch
from
April 10, 2017 10:57
a5b986b
to
d8c1991
Compare
ivovandongen
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Apr 11, 2017
Closed
This was referenced May 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attempt of fixing #1729
Polygon
PolygonOptions
@ivovandongen Could you review/add more comments on C++ part?
At the moment, still remains the following:
Anything else?
BTW, does the overall PR make sense? Would you tackle it using a different approach?