This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Track state of initial overlain views margins #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,6 +376,10 @@ public int getCompassGravity() { | |||
| */ | |||
| @UiThread | |||
| public void setCompassMargins(int left, int top, int right, int bottom) { | |||
| compassMargins[0] = left; | |||
There was a problem hiding this comment.
Same instructions (with different variables) are also present in setLogoMargins and setAttributionMargins methods.
What about extracting them into a method passing an array and left, top, right and bottom variables and remove the duplication?
There was a problem hiding this comment.
Good call, has been addressed in 04949dc
tobrun
force-pushed
the
9379-state-of-initial-margins
branch
from
ff9eb9b
to
04949dc
Compare
tobrun
force-pushed
the
9379-state-of-initial-margins
branch
from
04949dc
to
271e6d4
Compare
|
Moving this PR to android-v5.1.3 milestone so we can cherry-pick it for that release. cc @zugaldia |
tobrun
added a commit
that referenced
this pull request
Aug 18, 2017
tobrun
added a commit
that referenced
this pull request
Aug 19, 2017
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Sep 1, 2017
* release-ios-v3.6.0-android-v5.1.0: (89 commits) [tests] Cherry-pick OfflineDatabase::databaseTableColumns [tests] Enforce the schema downgrade behavior [core] Remove database on schema downgrade [ios] Set location to nil until the user's location is determined [ios] Support iOS 11 location usage descriptions [ios] Print Xcode and SDK version during packaging [build] Don't fail hard for unknown warning groups [build] Don't use maybe-uninitialized and misleading-indentation in Clang, since they're not implemented there [ios] Fix heading update loop [ios] Document annotations-as-features limitations w/feature querying [android] - update config for next reelease [android] - update changelog for v5.1.3 bumped MAS version number [android] - avoid IndexOutOfBounds when destroying map object [android] - enable location change animation of MyLocationView by default [android] - re-add projectedMeters [android] - create smallest possible LatLngBounds when visible region crosses the dateline [android] - provide compability with Samsung devices forcing 3-4 array matrix length [android] - keep state of initial overlain views margins (mapbox#9391) [ios] Update pods spec for iOS v3.6.2 (mapbox#9806) ... # Conflicts: # platform/android/MapboxGLAndroidSDK/proguard-rules.pro # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/Mapbox.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AnnotationManager.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapGestureDetector.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMapOptions.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/Projection.java # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java # platform/android/dependencies.gradle # src/mbgl/renderer/painter_line.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9379, this PR tracks the set value of margins instead of relying on the value at that time. This is needed for a correct
MapboxMap#setPaddingintegration.