This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove preview image integration #9657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-remove-preview
branch
from
b1f661f
to
57eb2e7
Compare
tobrun
force-pushed
the
tvn-remove-preview
branch
from
57eb2e7
to
82d16b7
Compare
tobrun
changed the title
zugaldia
approved these changes
Aug 1, 2017
There was a problem hiding this comment.
This is not ideal and while we wait for a stable Android Studio 3.0 (that will introduce a the @sample annotation), we should remove this integration for now.
Could you ticket the follow up work required to bring this pic back once AS3 gets released?
I was planning to update the original ticket in #9480, with latest status (it already contains links to |
|
content of #9480 has been updated to reflect the state of this PR, going to merge. |
tobrun
added a commit
that referenced
this pull request
Aug 1, 2017
tobrun
added a commit
that referenced
this pull request
Aug 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes integration for our preview thumbnail in the layout editor of Android Studio.
Current preview image is packaged within the aar and if not filtered out by proguard. This image will be packaged with the apk of end users. This is not ideal and while we wait for a stable Android Studio 3.0 (that will introduce a the
@sampleannotation), we should remove this integration for now.Refs #9480