This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Compability for Samsung devices forcing 3-4 array vector length #9746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
suggested changes
Aug 10, 2017
| // For the purposes of this class the first 4 values of the | ||
| // rotation vector are sufficient (see crbug.com/335298 for details). | ||
| // Only affects Android 4.3 | ||
| if (truncatedRotationVectorValue == null) { |
There was a problem hiding this comment.
It seems that this condition is always false because we're initializing it here https://github.com/mapbox/mapbox-gl-native/blob/76d1d87cc1c54fbe72549810610159306555b729/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java#L814 so it could be removed. Am I missing something?
There was a problem hiding this comment.
correct, fixed in 3c4810e
tobrun
force-pushed
the
9745-samsung-sensor-bug
branch
from
76d1d87
to
3c4810e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9745, as noted in issue and shown in chromium tracker. A couple of 4.3 Samsung devices throw an exception when the rotation vector size is larger as 4. This PR provides compatibility those devices.
Haven't been able to verify this issue myself, default implementation still works.