This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Avoid IndexOutOfBoundsException when destroying map object #9789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
reviewed
Aug 17, 2017
| long[] ids = null; | ||
| if (nativeMapView != null) { | ||
| ids = nativeMapView.addMarkers(markers); | ||
| long[] ids = nativeMapView.addMarkers(markers); |
There was a problem hiding this comment.
Looks like the if (nativeMapView != null) check was lost during the refactor. Wouldn't we want to reintroduce it?
There was a problem hiding this comment.
Same with the other two cases below.
tobrun
force-pushed
the
tvn-map-destroy-add-annotation
branch
from
4710dbe
to
7335566
Compare
zugaldia
approved these changes
Aug 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9785