This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Document annotations-as-features limitations w/feature querying #9807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
approved these changes
Aug 18, 2017
platform/ios/src/MGLMapView.h
Outdated
| @@ -1254,6 +1254,11 @@ MGL_EXPORT IB_DESIGNABLE | |||
| `-[MGLVectorSource featuresInSourceLayersWithIdentifiers:predicate:]` and | |||
| `-[MGLShapeSource featuresMatchingPredicate:]` methods on the relevant sources. | |||
|
|
|||
| The returned features may also include annotations that do not conform to | |||
| `MGLFeature`. These annotations will not be object-equal to those that were | |||
| originally added to the map. To query the map for annotations, use | |||
There was a problem hiding this comment.
It’s difficult to convey the nuances around object wrapping, but maybe this will help:
The returned features may also include features corresponding to annotations. These features are not object-equal to the
MGLAnnotationobjects that were originally added to the map.
There was a problem hiding this comment.
Nice, I’ve updated this PR to use your verbiage.
friedbunny
force-pushed
the
fb-annotations-as-features
branch
from
a67a972
to
78f16a6
Compare
Also move visibleAnnotations next to visibleAnnotationsInRect:.
friedbunny
force-pushed
the
fb-annotations-as-features
branch
from
78f16a6
to
acb8199
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this @1ec5 comment from #9540 (review):
Also reorders
visibleAnnotationsto be immediately abovevisibleAnnotationsInRect:.