This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Clear out mapCallback's OnMapReadyCallbacks on onDestroy #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution @robindarby, to allow our CI to execute I will have to push your changes in a seperate PR. You can find that PR here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a state where MapView's
OnMapChangedListener.onMapReadyCallbackList.onMapReady()callbacks are called, but memberdestroyed== true (i.e.onDestroy()has been called).This can cause any callback provided to
getMapAsyncto be executed even though the MapView is in a destroyed state!The following patch calls
clear()on the list of callbacks, preventing code execution inOnMapChangedListener.onMapReady().