Primitive implementation of line intersect #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
OttyLab
force-pushed
the
implement-line-intersect
branch
2 times, most recently
from
e84d36e to
d7fc569
Compare
LukasPaczos
reviewed
Jan 17, 2022
There was a problem hiding this comment.
LGTM with one small change request
The handling of line segment endpoint is different from Turf-Swift.
Looks like TurfJS is inclusive as well so we might want to fix this up on the Java side.
Would you be able to cut a separate ticket/PR?
| @@ -26,6 +26,43 @@ private TurfMisc() { | |||
| throw new AssertionError("No Instances."); | |||
| } | |||
|
|
|||
| /** | |||
| * Takes lines {@link LineString} and returns intersect points. | |||
There was a problem hiding this comment.
It'd be good to mention time complexity and that it's not as efficient as the JS counterpart.
There was a problem hiding this comment.
Thanks, I updated the comment
OttyLab
force-pushed
the
implement-line-intersect
branch
from
d7fc569 to
6379bb0
Compare
|
I opened a PR which fixes |
OttyLab
force-pushed
the
implement-line-intersect
branch
from
6379bb0 to
8b07285
Compare
|
By following this comment, I've picked up the fix of |
OttyLab
force-pushed
the
implement-line-intersect
branch
from
8b07285 to
d49e824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement line intersect which is equivalent to turf.lineIntersect with a primitive manner.
Discussion
ifconditions causes the difference. If they are likevarA >= 0 && varA <= 1, the behavior becomes same. Which Swift/Java is the expected? (This is because the test is slightly different from Turf-Swift)