Moved MathUtils from mapbox-java2.x telemetry to mapbox-java3.0 servi… #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
requested changes
Feb 12, 2018
There was a problem hiding this comment.
This addresses mapbox/mapbox-gl-native#10999 (diff)
After removing never used methods convertNativeBearing and differenceBetweenAngles this should be ready to go 🚀
| * @param nativeBearing bearing value coming from core | ||
| * @return bearing in degrees starting from 0 rotating clockwise | ||
| */ | ||
| public static double convertNativeBearing(double nativeBearing) { |
There was a problem hiding this comment.
Not used in MapboxGLAndroidSDK so no need to expose it.
We should remove it.
| * @param beta Second angle in degrees | ||
| * @return Smallest angle between two angles. | ||
| */ | ||
| public static double differenceBetweenAngles(double alpha, double beta) { |
osana
force-pushed
the
osana-math-utils
branch
from
86436bd
to
99806c9
Compare
This was referenced Feb 13, 2018
tobrun
requested changes
Feb 13, 2018
There was a problem hiding this comment.
Let's hold with merging until we get consensus on mapbox/mapbox-gl-native#11182 (comment).
|
Closing here without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MathUtils to services-core.
It used to be part of telemetry