Add static XCFramework option to packager scripts #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds LINK_TYPE parameters to create-xcframework.sh, build-dependency.sh, and package-mapbox-maps.sh - Updates build_dependency.sh and create-xcframework.sh to make SCHEME default to the value passed for NAME - Updates create-xcframework.sh to make PROJECT default to the value passed for NAME suffixed with .xcodeproj - Forces LLVM_LTO=NO when running xcodebuild archive because otherwise xcodebuild -create-xcframework was failing with "error: unable to find any architecture information in the binary at '…/iOS-Simulator.xcarchive/Products/Library/Frameworks/ MapboxMobileEvents.framework/MapboxMobileEvents': Unknown header: 0xb17c0de" - Add a separate README with adjusted installation instructions for static XCFrameworks.
macdrevx
added
the
feature 🍏
julianrex
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
mapbox-maps-ioschangelog:<changelog>Added a static XCFramework direct download installation option.</changelog>.Summary of changes
LINK_TYPEparameters tocreate-xcframework.sh,build-dependency.sh, andpackage-mapbox-maps.shbuild_dependency.shandcreate-xcframework.shto makeSCHEMEdefault to the value passed forNAMEcreate-xcframework.shto makePROJECTdefault to the value passed forNAMEsuffixed with.xcodeprojLLVM_LTO=NOwhen runningxcodebuild archivebecause otherwisexcodebuild -create-xcframeworkwas failing witherror: unable to find any architecture information in the binary at '…/iOS-Simulator.xcarchive/Products/Library/Frameworks/MapboxMobileEvents.framework/MapboxMobileEvents': Unknown header: 0xb17c0deUser impact
This change lays the groundwork for offering a static XCFramework option.