[ornaments] Refactor visibility options for the logo and attribution button #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkiley
added
the
breaking change ⚠️
jmkiley
force-pushed
the
jk/ornament-visibility
branch
from
36efe8b
to
666f045
Compare
julianrex
approved these changes
May 6, 2021
neelmistry94
reviewed
May 7, 2021
| public override var isHidden: Bool { | ||
| didSet { | ||
| if isHidden { | ||
| Log.warning(forMessage: "Attribution must be enabled if you use data from sources that require it. See https://docs.mapbox.com/help/getting-started/attribution/ for more details.", category: "Ornaments") |
There was a problem hiding this comment.
I'm assuming this language was checked by @sbma44
There was a problem hiding this comment.
neelmistry94
approved these changes
May 7, 2021
julianrex
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ioschangelog:<changelog></changelog>.Summary of changes
The
_isVisibleproperty on the logo view and attribution button's ornament options is nowvisibility. This adds consistency with the compass and scale bar'svisibilityproperty.Refactor
OrnamentOptionsso that there is oneBaseOrnamentOptionsstruct, rather than individual structs for each ornament.This PR also adds an
Log.errorthat is shown when the logo or attribution button is hidden.User impact (optional)