Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tap gesture recognizer public on annotation managers + clean up #451

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented Jun 9, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR makes the following changes:

  • The tapRecognizer on annotation managers is now public. It can be used to coordinate with custom gestures that a developer may want to add on the map.
  • Annotations no longer have a type var since it's redundant.

@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/make-tap-recognizer-public-on-annotation-manager branch from 01576dd to 0e507f9 Compare June 9, 2021 20:05
@nishant-karajgikar nishant-karajgikar merged commit cd437a0 into main Jun 10, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/make-tap-recognizer-public-on-annotation-manager branch June 10, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants