Prevent complete animators from causing drawing #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
bug 🪲
|
Could we run device tests before merging this PR? You can use |
Comment on lines
+3
to
+16
| internal protocol MapViewDependencyProviderProtocol { | ||
| func makeMetalView(frame: CGRect, device: MTLDevice?) -> MTKView | ||
| func makeDisplayLink(window: UIWindow, target: Any, selector: Selector) -> DisplayLinkProtocol? | ||
| } | ||
|
|
||
| internal final class MapViewDependencyProvider: MapViewDependencyProviderProtocol { | ||
| func makeMetalView(frame: CGRect, device: MTLDevice?) -> MTKView { | ||
| MTKView(frame: frame, device: device) | ||
| } | ||
|
|
||
| func makeDisplayLink(window: UIWindow, target: Any, selector: Selector) -> DisplayLinkProtocol? { | ||
| window.screen.displayLink(withTarget: target, selector: selector) | ||
| } | ||
| } |
There was a problem hiding this comment.
🙇🏾 this is awesome.. We've needed to do this for a long time!
macdrevx
commented
Jun 30, 2021
Comment on lines
+9
to
+13
| let makeMetalViewStub = Stub<MakeMetalViewParams, MockMetalView?>(defaultReturnValue: nil) | ||
| func makeMetalView(frame: CGRect, device: MTLDevice?) -> MTKView { | ||
| makeMetalViewStub.returnValueQueue.append(MockMetalView(frame: frame, device: device)) | ||
| return makeMetalViewStub.call(with: MakeMetalViewParams(frame: frame, device: device))! | ||
| } |
There was a problem hiding this comment.
Add return value generator block
nishant-karajgikar
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #469
Pull request checklist:
Summary of changes