Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshotter attribution #567

Merged
merged 9 commits into from
Aug 4, 2021
Merged

Snapshotter attribution #567

merged 9 commits into from
Aug 4, 2021

Conversation

julianrex
Copy link
Contributor

PRs must be submitted under the terms of our Contributor License Agreement CLA.

WIP
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

User impact (optional)

neelmistry94
neelmistry94 reviewed Jul 29, 2021
View reviewed changes
Sources/MapboxMaps/Ornaments/MapboxInfoButtonOrnament.swift Outdated
static let metricsEnabledKey = "MGLMapboxMetricsEnabled"
static let telemetryURL = "https://www.mapbox.com/telemetry/"
}
internal struct Ornaments {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this struct feels mislabeled, does not feel like it is Ornaments

neelmistry94
neelmistry94 reviewed Aug 3, 2021
View reviewed changes
Sources/MapboxMaps/Foundation/MapboxMap.swift
return attributions
}
}

// MARK: - Testing only! -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you did not edit this as part of this PR, but I think adding code just for testing in the class itself is not a good practice. Test code extensions can maybe sit in the test classes or something. It also raises an interesting question of why this is needed and if we can refactor.

Although this is probably a separate conversation

neelmistry94
neelmistry94 reviewed Aug 3, 2021
View reviewed changes
...apboxMapsTests/Snapshot/Snapshot.xcassets/testSnapshotAttribution-200.imageset/Contents.json
@@ -0,0 +1,21 @@
{
"images" : [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these for testing purposes only? If so, we can add just a single file outside of the asset catalog to avoid some bloating of files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this PR for an example

@julianrex
Copy link
Contributor Author

Noting that we are planning to evaluate using a UIImageView and layout constraints as a future refactor.

@julianrex julianrex marked this pull request as ready for review August 4, 2021 14:30
@julianrex julianrex enabled auto-merge (squash) August 4, 2021 14:31
@julianrex julianrex merged commit 2bf525e into main Aug 4, 2021
@julianrex julianrex deleted the jrex/attribution branch August 4, 2021 14:34
@julianrex julianrex mentioned this pull request Aug 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelmistry94 neelmistry94 neelmistry94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianrex @neelmistry94