Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image comparison for recent snapshot attribution tests #573

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Aug 4, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why. Updated.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'

Summary of changes

Follows on from #567, fixing the image comparisons for snapshot tests.

Previously an xcassets package was used, and although tests past with Xcode 13, they failed under Xcode 12.5. I have removed the xcassets package.

@julianrex julianrex marked this pull request as ready for review August 4, 2021 19:37
@julianrex julianrex added the skip changelog Add this label if this item does not need to be included in the changelog label Aug 4, 2021
@julianrex julianrex merged commit 7200592 into main Aug 4, 2021
@julianrex julianrex deleted the jrex/attribution-build branch August 4, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants