Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace syncAnnotations with property setter #614

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Replace syncAnnotations with property setter #614

merged 2 commits into from
Aug 25, 2021

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Aug 25, 2021 •
edited
Loading

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Existing tests have been updated
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

  • The syncAnnotations(_:) method on each annotation manager has been replaced by a publicly accessible setter on the annotations property.

@macdrevx macdrevx added skip changelog Add this label if this item does not need to be included in the changelog breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published labels Aug 25, 2021
@macdrevx macdrevx merged commit 91b239b into main Aug 25, 2021
@macdrevx macdrevx deleted the ah/annotations-setter branch August 25, 2021 15:18
@chezzdev chezzdev mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-karajgikar nishant-karajgikar nishant-karajgikar approved these changes

Assignees
No one assigned
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macdrevx @nishant-karajgikar