-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Turf GeoJSON usage to GeoJSONObject and JSONValue #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
dependencies
Pull requests that update a dependency file
labels
Sep 28, 2021
1ec5
changed the title
1ec5 turf geojson conform 154
Migrate Turf GeoJSON usage to GeoJSONObject and JSONValue
Sep 28, 2021
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
September 28, 2021 17:21
69dcf0e
to
02ac3db
Compare
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
September 29, 2021 06:58
02ac3db
to
11c3965
Compare
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
September 29, 2021 09:17
ed429ce
to
2db44f9
Compare
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
September 29, 2021 11:14
70cc847
to
04a8e3a
Compare
macdrevx
reviewed
Sep 29, 2021
macdrevx
reviewed
Sep 29, 2021
macdrevx
reviewed
Sep 29, 2021
macdrevx
reviewed
Sep 29, 2021
guard case .number(.double(2.0)) = feature.identifier else { | ||
guard feature.identifier == 2.0 else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this. Very nice.
macdrevx
reviewed
Sep 29, 2021
macdrevx
reviewed
Sep 29, 2021
Tests/MapboxMapsTests/Foundation/Integration Tests/FeatureQueryingTest.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com>
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
September 29, 2021 19:26
aea129f
to
928dc5e
Compare
macdrevx
approved these changes
Sep 29, 2021
This build is failing, presumably due to #695 so unrelated to this PR:
#720 proposes making giving these parameters default arguments so that these calls wouldn’t have to be modified. |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the GeoJSON API changes in mapbox/turf-swift#154 and Turf v2.0.0-rc.2. Most of the changes are in generated code and in tests, though some examples have also changed in minor ways. There is one breaking change on top of the Turf changes: the generic parameter on the
Style.updateGeoJSONSource<T: GeoJSONObject>(withId:geoJSON:)
method has been removed. Instead of passing in the expected GeoJSON object type, you perform pattern matching on the return value usingcase let
. (#715)Depends on mapbox/turf-swift#154.
/cc @mapbox/maps-ios