Refine and expose TileRegionObserver API #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
the
skip changelog
macdrevx
force-pushed
the
ah/tile-store-observer-refinement
branch
from
f89ed88
to
32af18f
Compare
jmkiley
approved these changes
Oct 5, 2021
Also makes QueriedFeature.feature non-optional
macdrevx
force-pushed
the
ah/tile-store-observer-refinement
branch
from
71099da
to
b0614c6
Compare
Merged
1ec5
reviewed
Oct 6, 2021
| XCTAssertEqual(observer.onRegionLoadFinishedStub.invocations.count, 1) | ||
| let parameters = try XCTUnwrap(observer.onRegionLoadFinishedStub.parameters.first) | ||
| XCTAssertEqual(parameters.id, id) | ||
| guard case .success(let tileRegion) = parameters.region else { |
There was a problem hiding this comment.
I’m getting these errors locally in Xcode 12.4:
Swift Compiler Error Group
/path/to/mapbox-maps-ios/Tests/MapboxMapsTests/Offline/TileStoreObserverWrapperTests.swift:55:33: Definition conflicts with previous value
/path/to/mapbox-maps-ios/Tests/MapboxMapsTests/Offline/TileStoreObserverWrapperTests.swift:42:13: Previous definition of 'tileRegion' is here
Swift Compiler Warning Group
/path/to/mapbox-maps-ios/Tests/MapboxMapsTests/Offline/TileStoreObserverWrapperTests.swift:55:33: Immutable value 'tileRegion' was never used; consider replacing with '_' or removing it
| XCTFail("Expected region parameter to be Result.success, but found \(parameters.region)") | ||
| return | ||
| } | ||
| XCTAssertTrue(tileRegion === tileRegion) |
There was a problem hiding this comment.
How would an NSObject ever be pointer-unequal to itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
Summary of changes
Breaking Changes
QueriedFeature.featureis no longer optionalTypeConversionError.unsuccessfulConversionOther Public API Changes
TileStore.subscribe(_:)which can be used to observe aTileStore's activity. The API design deviates from Android's add/remove observer API so that we can adapt the developer-providedTileStoreObserverinto aMapboxCommon_Private.TileStoreObserverwithout needing to use global state or something like Objective-C associated objects to keep track of which wrapper instance goes with with developer-provided observer.TileStoreObserverprotocolOther Internal Changes
DebugViewControllercleanupFeature.init(_:)now always succeedsTileStoreObserverCancelableTileStoreObserverWrapperTileStoreProtocoland makesTileStoreconform