Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[location] Rely on consumer provided view models directly to customize location pucks #86

Merged
merged 4 commits into from
Feb 9, 2021
Merged

[location] Rely on consumer provided view models directly to customize location pucks #86

merged 4 commits into from
Feb 9, 2021

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented Feb 8, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog>Rely on consumer provided view models directly to customize location pucks </changelog>.

Summary of changes

This PR makes the LocationManager directly use consumer provided viewModels (PuckModelLayerViewModel and LocationIndicatorLayerViewModel) instead of calling a closure.

@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/make-location-puck-equatable branch 2 times, most recently from 732ce98 to 0ae8474 Compare February 8, 2021 17:26
@nishant-karajgikar nishant-karajgikar added the bug 🪲 Something is broken! label Feb 8, 2021
@nishant-karajgikar nishant-karajgikar self-assigned this Feb 8, 2021
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/make-location-puck-equatable branch from 18a08e1 to d6cc937 Compare February 8, 2021 21:51
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/make-location-puck-equatable branch from 852feec to 50c7f11 Compare February 8, 2021 22:02
@nishant-karajgikar nishant-karajgikar changed the title [location] Fix conformance of Location Puck enum to Equatable [location] Rely on consumer provided view models directly to customize location pucks Feb 8, 2021
@nishant-karajgikar nishant-karajgikar added breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published and removed bug 🪲 Something is broken! labels Feb 9, 2021
@nishant-karajgikar nishant-karajgikar merged commit 87e4f85 into main Feb 9, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/make-location-puck-equatable branch February 9, 2021 16:04
persidskiy pushed a commit that referenced this pull request Feb 24, 2023
@maios
Merge pull request #86 from mapbox/ci-internal-main-merge
f86db34 
internal to main merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdrevx macdrevx macdrevx approved these changes

Assignees

@nishant-karajgikar nishant-karajgikar

Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishant-karajgikar @macdrevx