Migrate Turf GeoJSON usage to GeoJSONObject and JSONValue #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
build
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
49b4b1d to
b64a0a5
Compare
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
b64a0a5 to
0677f3c
Compare
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
0677f3c to
689c8a6
Compare
Udumft
reviewed
Sep 29, 2021
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
689c8a6 to
cc20b90
Compare
1ec5
force-pushed
the
1ec5-maps-v10.0.0-rc.10
branch
from
71a708d to
5c8a048
Compare
Factored out EventLocation to begin migrating some ad-hoc event dictionaries to Codable structs.
1ec5
force-pushed
the
1ec5-turf-geojson-conform-154
branch
from
cc20b90 to
1412564
Compare
4 tasks
|
Overall looks good to me. I guess build failures will be resolved after finalizing update to the latest version of Mapbox Maps. |
MaximAlien
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated Turf GeoJSON usage to GeoJSONObject and JSONValue. Factored out EventLocation to begin migrating some ad-hoc event dictionaries to Codable structs.
Depends on mapbox/turf-swift#154, mapbox/mapbox-maps-ios#715, and #3413. There are no additional public-facing changes on top of the Turf changes.
/cc @mapbox/navigation-ios