Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[annotation-plugin] add support for clustering #1168

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[annotation-plugin] add support for clustering #1168

merged 1 commit into from
Feb 9, 2021

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Dec 21, 2020

This PR adds a default implementation for clustering support with the symbol of annotation plugin. If exposed functionality is too limited, users can roll their own version using the circle/symbol layer.

Current API is limited to changing:

  clusterRadius;
  clusterMaxZoom;
  colorLevels;
  circleRadius;
  textColor;
  textSize;
  textField;

ezgif com-video-to-gif(18)

closes #648

@tobrun tobrun requested a review from Chaoba December 21, 2020 14:04
@tobrun tobrun self-assigned this Dec 21, 2020
Chaoba
Chaoba approved these changes Dec 22, 2020
View reviewed changes
...ain/java/com/mapbox/mapboxsdk/plugins/testapp/activity/annotation/ClusterSymbolActivity.java
symbolManager.delete(symbols);
if (locations.features().size() < amount) {
amount = locations.features().size();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use Math.min function

@fantasyado
Copy link

Want to know when will this feature be released...

@Kephas3
Copy link

Kephas3 commented Feb 5, 2021

Hello,

When do you think this PR will be merged ?

Thanks :)

@tobrun tobrun merged commit b97bb08 into main Feb 9, 2021
@Kephas3 Kephas3 mentioned this pull request Feb 10, 2021
Closed
5 tasks
@Progdrasil
Copy link

Will there be a release with this feature soon? The last release of the annotation plugin dates back to august 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaoba Chaoba Chaoba approved these changes

Assignees

@tobrun tobrun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose clustering configuration
5 participants
@tobrun @fantasyado @Kephas3 @Progdrasil @Chaoba