Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maps SDK 8.2.0 #999

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Maps SDK 8.2.0 #999

merged 1 commit into from
Jul 25, 2019

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith commented Jun 26, 2019 •
edited
Loading

This pr is to track the eventual upgrade of the plugins' dependency on the Maps SDK for Android to 8.2.0.

  • 8.2.0-alpha.1
  • 8.2.0-alpha.2
  • 8.2.0-alpha.3
  • 8.2.0-beta.1
  • 8.2.0

cc @mapbox/maps-android

@langsmith
Copy link
Contributor Author

I didn't find any noteworthy issues with 8.2.0-alpha.1. I assume that this is expected behavior from View-based annotations and another reason to stick with SymbolLayers:

ezgif com-resize (1)

@tobrun
Copy link
Member

tobrun commented Jun 27, 2019

I assume that this is expected behavior from View-based annotations

yes

@langsmith
Copy link
Contributor Author

No noteworthy issues with 8.2.0-alpha.2. There's a weird transition from the 2nd Style.MAPBOX_STREETS style to Style.LIGHT in some test app examples:

ezgif com-resize (3)

@LukasPaczos
Copy link
Contributor

@pozdnyakov can ^^^ be caused by mapbox/mapbox-gl-native#15016?

@langsmith
Copy link
Contributor Author

For 8.2.0-alpha.3 QA:

  1. Style change flickering mentioned above, is still visible.

  2. Source in use W-level log message

When style is changed in LineChangeActivity

2019-07-19 09:21:51.192 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'mapbox-android-line-source-1' is in use, cannot remove

When style is changed in TrafficActivity

2019-07-19 09:28:57.650 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'traffic' is in use, cannot remove

When style is changed in CircleActivity

2019-07-19 09:30:17.052 19245-19245/com.mapbox.mapboxsdk.plugins.testapp W/Mbgl: {plugins.testapp}[General]: Source 'mapbox-android-circle-source-2' is in use, cannot remove

and so on...

  1. Could be good to enable buildings when BuildingActivity starts, rather than them not appearing and the user having to press the FAB.

@LukasPaczos
Copy link
Contributor

Style change flickering mentioned above, is still visible.

Probably resolved with mapbox/mapbox-gl-native#15127. Targetting 8.3.0 as of now.

@LukasPaczos LukasPaczos mentioned this pull request Jul 22, 2019
Merged
@LukasPaczos
Copy link
Contributor

Source in use W-level log message

Fixed in mapbox/mapbox-gl-native#15191.

@langsmith
Copy link
Contributor Author

I did QA for alpha.3 but forgot to actually push my bump to this pr. QA was not done for beta.1.

I just bumped this pr to stable 8.2.0.

@langsmith langsmith requested a review from tobrun July 24, 2019 22:06
@langsmith langsmith added the ready for review When your PR has been personally reviewed, its time for an external contributors to approve label Jul 24, 2019
@langsmith langsmith requested review from LukasPaczos and removed request for tobrun July 24, 2019 22:07
@langsmith langsmith merged commit 935e156 into master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees
No one assigned
Labels
ready for review When your PR has been personally reviewed, its time for an external contributors to approve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langsmith @tobrun @LukasPaczos