-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package for pip install #202
Conversation
setup.py
Outdated
'toml>=0.10', | ||
'torch>=1.1', | ||
'torchvision>=0.3', | ||
'tqdm>=4.32', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you come up with this list and the versions? List from requirements.in
and then manually getting the versions from the requirements.txt
lockfile? Then why is it >=
above? Can we somehow automate this by parsing the requirements files? Otherwise updating dependencies gets even more complicated than it is already right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly. And I did not want to specify exact versions as the solver will likely need to some flexibility for installation into a larger project. As an alternative to >=
, we could specify ~=
to enforce a compatible version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the requirements to enforce compatible versions with ~=
, except for osmium==2.15.2
, which requires an exact version due a known issue with their latest release
osmcode/pyosmium#123
Automatically parsing the requirements.txt
is possible, but would need to update for less strict versioning, and is generally not advised
Could also worth to add an rs entry point:
|
@devinaconley Humm, i think @daniel-j-h point is less If you look on HTH, |
@ocourtin responded to that part in line with the original comment ^ |
Thanks! |
Allow installation of
robosat
package with pip. This could be hosted on PyPI or installed directly from Github.e.g.