Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marker-symbol is too ambiguous and/or no longer supported #37

Open
varna opened this issue Nov 21, 2022 · 0 comments
Open

marker-symbol is too ambiguous and/or no longer supported #37

varna opened this issue Nov 21, 2022 · 0 comments

Comments

@varna
Copy link

varna commented Nov 21, 2022

            // OPTIONAL: default ""
            // a symbol to position in the center of this icon
            // if not provided or "", no symbol is overlaid
            // and only the marker is shown
            // Allowed values include
            // - Icon ID
            // - An integer 0 through 9
            // - A lowercase character "a" through "z"
            "marker-symbol": "bus",
  • bus renders as an empty marker on GitHub preview, so it probably doesn't work anymore
  • what is symbol? Is it JS Symbol? Is it google maps icon name? Is it from Leaflet? This is too ambiguous for a spec.
  • what is Icon ID? Where can you get one? Is there a list? Can I add my own? Can I use iconfont id? How do I load an iconfont in a .geojson file? /s
  • An integer 0 through 9 and A lowercase character "a" through "z" probably means You can render a character inside of marker if you provide an integer or a lowercase letter as value?
  • And there's no mention of the possibility to load icons from URL.

This spec property is horrible and should be properly redefined with a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant