-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doesn't work with jsdom 0.2.0 #4
Comments
Have you tried it with latest stable? |
Yeah, fails on node 0.4.2 with jsdom 0.2.0... works fine with jsdom 0.1.23. |
Is that when using the examples or scraping a different site? |
Just the first simple twitter example in your README. |
Seems like it's probably a JSDOM issue. |
I don't have that issue though, but yeah, seems jsdom doesn't want to play. |
Had the same issue. fixed with change to scraper.js replaced __dirname+'/../deps/jquery-1.3.2.js' seems to be an issue loading the file in jsdom.jQuerify call - path is correct and permissions are fine so not sure what the problem is. |
This issue isn't solved. I had the same problem with
I actually upgrade though to |
Tried @jma3s fix, but still get that error.
|
Mine was fixed by updating jQuery ala @jma3s. I used 1.6.1. |
The scraper is now updated to use jQuery 1.6.1 and is pushed to npm. @mofle Do you get that error with all pages? And are you using latest jsdom? |
There is also an issue with jsdom 0.2.0 which has been fixed in 0.2.1 though it has not been yet pushed to npm. Also line 57 of scrape.js is still referring to jQuery 1.3.2. After switching it to the supplied 1.6.1 library and changing the require statement to point to jsdom@0.2.1, scraper is working as expected. p.s.: I'm currently using node v0.5.0-pre. |
Silly me, pushed update that uses jQuery 1.61. |
I did a manual uninstall of jsdom via npm: npm uninstall jsdom from within the scraper directory project/node_modules/scraper and then ran this: |
I'm getting issues when trying to run the example app with Node 0.4.0 and JSDom 0.2.0..
Here's the stacktrace
The text was updated successfully, but these errors were encountered: