Add group layer support #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'd really appreciate if this gets delayed until #135, otherwise it's going to be 10x more pain to merge it... |
|
@alexdevteam Okie smokie. It can wait. |
|
#135 has been merged now; You are free to reimplement the changes now (and I am really sorry about all the changes and modularization) |
Anti-Alias
commented
Feb 10, 2022
| @@ -114,18 +114,18 @@ impl Map { | |||
| } | |||
|
|
|||
| /// An iterator that iterates over all the layers in a map, obtained via [`Map::layers`]. | |||
| pub struct LayerIter<'map> { | |||
| pub struct MapLayerIter<'map> { | |||
There was a problem hiding this comment.
Changed name to disambiguate from new GroupLayerIter
|
Hah, no need to apologize. |
aleokdev
reviewed
Feb 10, 2022
bjorn
approved these changes
Feb 10, 2022
aleokdev
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.