Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer tint color; Fix Color parsing issues #150

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Feb 9, 2022

Closes #149, closes #85, fixes #148.

@aleokdev
Copy link
Contributor Author

aleokdev commented Feb 9, 2022

I thought this would be my first nonbreaking PR, but sadly the addition of the alpha member in Color makes it breaking.

@aleokdev aleokdev added the breaking This change breaks backwards-compatibility label Feb 9, 2022
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one small issue.

src/properties.rs Outdated Show resolved Hide resolved
bjorn
bjorn previously approved these changes Feb 9, 2022
@bjorn
Copy link
Member

bjorn commented Feb 9, 2022

Wait a sec, you're still missing the changelog entry!

@aleokdev aleokdev merged commit ce73c54 into mapeditor:master Feb 9, 2022
@aleokdev aleokdev deleted the tint-color branch February 9, 2022 15:44
@aleokdev aleokdev added this to the 0.10.0 milestone Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change breaks backwards-compatibility bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Color tests Color parsing does not take alpha into account Parse layers' tint color
2 participants