Remove Data types from the interface
#163
Conversation
|
I'd love to use a proc macro instead of |
|
|
|
Had to end up making both |
Yeah, the inconsistency isn't very nice, and in fact I've been struggling with the same in Tiled, for example to avoid placing tile objects in these object groups and workarounds for assigning IDs to these objects, which are normally counted per map. But I guess we can live with it. |
| map, | ||
| group, | ||
| index: 0, | ||
| } |
There was a problem hiding this comment.
What is the logic behind these reformattings? Here it's wrapping them all on their own line, but just a few lines up you removed some wrapping to form Ok((Self { layers }, properties)). I could be fine with either notation, but why keep changing these around?
There was a problem hiding this comment.
No reason for it, just rustfmt doing its thing.
There was a problem hiding this comment.
Can we do a single pass of rustfmt to avoid these changes, or does it actually like to change the wrapping back and forth?
* Add properties to `Object` * Add properties to `FiniteTileLayer` * Add properties to `Layer` * Add properties to `ImageLayer` * Add properties to `ObjectLayerData` * Remove `data()`; Replace `map()` * Add properties to `LayerTile` * `MapWrapper` -> `map_wrapper!` * Fix examples/tests * Limit visibility of data types * Make `Tile::collision` public again * Doc tweak Co-authored-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
Closes #162 & closes #158.