Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update next branch #271

Merged
merged 6 commits into from
May 26, 2023
Merged

Update next branch #271

merged 6 commits into from
May 26, 2023

Conversation

aleokdev
Copy link
Contributor

No description provided.

darkautism and others added 6 commits March 22, 2023 12:43
* Add WASM section to README

* Use wasm feature

* Fix

* [no ci] Changelog update

* Revert test changes
* Add `as_x` fns for layer types

* Add changelog

* Move methods to Layer, rename, better docs
* Update version

* Add load_tmx_map_from note

* Fix copypasta

* Fix indentation

* Change version in README
* Remove outdated doc

* Update changelog
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please don't use GitHub to merge current into next, since it should be possible to simply fast-forward next to current given that there is no new work submitted to next yet.

@aleokdev
Copy link
Contributor Author

How can I do that if the base branch is protected?

@bjorn bjorn merged commit 4f94470 into next May 26, 2023
@bjorn
Copy link
Member

bjorn commented May 26, 2023

How can I do that if the base branch is protected?

I wasn't sure so I just tried it. This seems to have worked, and automatically closed this PR as merged:

bjorn@thor:~/projects/rs-tiled$ git checkout next
Switched to branch 'next'
Your branch is up to date with 'origin/next'.
bjorn@thor:~/projects/rs-tiled$ git merge current
Updating 6dff214..4f94470
Fast-forward
 CHANGELOG.md          | 42 ++++++++++++++++++++++
 Cargo.toml            |  5 +--
 README.md             | 37 +++++++++++++++++++-
 examples/ggez/map.rs  |  8 ++---
 examples/sfml/main.rs |  9 +++--
 src/image.rs          |  8 +----
 src/layers/mod.rs     | 68 ++++++++++++++++++++++++++++++++++++
 src/map.rs            | 97 +++++++++++++++++++++++++++++++++++++++++++++++++--
 tests/lib.rs          | 45 +++++++-----------------
 9 files changed, 266 insertions(+), 53 deletions(-)
bjorn@thor:~/projects/rs-tiled$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To github.com:mapeditor/rs-tiled.git
   6dff214..4f94470  next -> next

I'm not sure exactly why this works. Maybe it is because an approved PR was open, or maybe it is because I'm admin. To be sure we could try it without PR next time the branch can just be fast-forwarded, and next time you try this. :-)

@aleokdev
Copy link
Contributor Author

I tried exactly that yet Github denied my push. Pretty sure it's because you're an admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants