Add content to text shape, fix kerning default value #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn
reviewed
Sep 1, 2023
|
TODO: Add width+height attrs |
|
Done |
bjorn
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow when adding text objects I forgot the most important thing of them: Their content. So there is currently no way to see the content of an object with the Text shape. I'm sorry for that. Sadly this change is breaking so it won't be featured until 0.12, but I'm considering releasing it just because of this.
Also fixes
kerning's default value, which should betrue. (https://docs.mapeditor.org/en/latest/reference/tmx-map-format/#text)