From 1bdf5929070a094609c498382c8d8d5a954053ed Mon Sep 17 00:00:00 2001 From: mwish Date: Sun, 17 Mar 2024 04:17:26 +0800 Subject: [PATCH] comment minor fix --- cpp/src/parquet/bloom_filter_reader_writer_test.cc | 4 ++-- cpp/src/parquet/column_writer_test.cc | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/cpp/src/parquet/bloom_filter_reader_writer_test.cc b/cpp/src/parquet/bloom_filter_reader_writer_test.cc index 9bc1ca84bd565..9d508c6320cdb 100644 --- a/cpp/src/parquet/bloom_filter_reader_writer_test.cc +++ b/cpp/src/parquet/bloom_filter_reader_writer_test.cc @@ -28,7 +28,7 @@ namespace parquet::test { TEST(BloomFilterReader, ReadBloomFilter) { - std::string dir_string(parquet::test::get_data_dir()); + std::string dir_string(get_data_dir()); std::string path = dir_string + "/data_index_bloom_encoding_stats.parquet"; auto reader = ParquetFileReader::OpenFile(path, false); auto file_metadata = reader->metadata(); @@ -59,7 +59,7 @@ TEST(BloomFilterReader, ReadBloomFilter) { TEST(BloomFilterReader, FileNotHaveBloomFilter) { // Can still get a BloomFilterReader and a RowGroupBloomFilter // reader, but cannot get a non-null BloomFilter. - std::string dir_string(parquet::test::get_data_dir()); + std::string dir_string(get_data_dir()); std::string path = dir_string + "/alltypes_plain.parquet"; auto reader = ParquetFileReader::OpenFile(path, false); auto file_metadata = reader->metadata(); diff --git a/cpp/src/parquet/column_writer_test.cc b/cpp/src/parquet/column_writer_test.cc index 4ec8ded16a7b0..46ac1e56811af 100644 --- a/cpp/src/parquet/column_writer_test.cc +++ b/cpp/src/parquet/column_writer_test.cc @@ -1706,8 +1706,7 @@ class TestBloomFilterWriter : public TestPrimitiveWriter { } std::shared_ptr> BuildWriterWithBloomFilter( - int64_t output_size = SMALL_SIZE, - const ColumnProperties& column_properties = ColumnProperties()); + int64_t output_size = SMALL_SIZE, const ColumnProperties& column_properties); std::unique_ptr builder_; BloomFilter* bloom_filter_; @@ -1761,7 +1760,7 @@ TYPED_TEST(TestBloomFilterWriter, Basic) { this->GenerateData(SMALL_SIZE); ColumnProperties column_properties; BloomFilterOptions options; - options.ndv = 10; + options.ndv = SMALL_SIZE; column_properties.set_bloom_filter_options(options); auto writer = this->BuildWriterWithBloomFilter(SMALL_SIZE, column_properties);