Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS MGLMapView missing most commits since Sept 4, 2020 #105

Closed
nnhubbard opened this issue Jul 6, 2021 · 3 comments
Closed

iOS MGLMapView missing most commits since Sept 4, 2020 #105

nnhubbard opened this issue Jul 6, 2021 · 3 comments

Comments

@nnhubbard
Copy link

For whatever reason, it seems that mapLibre was started using an older version of mapbox-gl-native-ios. I have compared the source and it seems that none of the commits since Sept. 4, 2020 have been added in mapLibre. See:

https://github.com/mapbox/mapbox-gl-native-ios/commits/main/platform/ios/src/MGLMapView.mm

Some of these are very important such as mapbox/mapbox-gl-native-ios@8689173#diff-2b12ba2cacef0e8c6a943690a80480a938985ff758d0b69cae5913c8d3cf9273 which clearly is still buggy in mapLibre because the fix has not been merged.

Are there plans to merge all of the fixes to MGLMapView that are in the mapbox-gl-native-ios project?

@petr-pokorny-1
Copy link
Contributor

The mapbox-gl-native was forked from d60fd30 - mgbl 1.6.0, mapbox-gl-native-ios from a139216 and mapbox-gl-native-android from 4c12fb2

mapbox-gl-native-ios and mapbox-gl-native-android depends on the core library (mapbox-gl-native) which was moved behind curtains by MapBox after May 7 2020 and code changes are no longer available for open-source community. So we took ios/android at the most recent version which is compatible (meaning it compiles and links) with the core library. Many commits in mapbox-gl-native-ios and mapbox-gl-native-android after this date have dependency on the core library and it is not possible simply cherry-pick them. From those with no dependency, we have cherry-picked some of them (please see the PR history) but some still remains to be cherry-picked.

Here is a list of changes which could be potentially cherry-picked.
We would welcome any help to break down these into tickets in this repo and cherry-pick them. The work is to inspect original changes, see if they were already done in MapLibre, check if the have any dependency on changes in the core library and create PR with cherry-picked changes.

Platform Title Link
iOS Explore: Expose styling for default user location view mapbox/mapbox-gl-native-ios#403
iOS Ask accuracy authorization when tracking mode is different from none mapbox/mapbox-gl-native-ios#406
iOS Switch background snapshot to periodic. mapbox/mapbox-gl-native-ios#412
iOS Add a flag to enforce using cached tiles mapbox/mapbox-gl-native-ios#416
iOS Fix content insets when automaticallyAdjustsScrollViewInsets is set to NO mapbox/mapbox-gl-native-ios#420
iOS Address crash when localFontFamilyName is nil mapbox/mapbox-gl-native-ios#467
iOS Location manager crash fix when a selector is not implemented mapbox/mapbox-gl-native-ios#474
iOS Add compass image as a sublayer mapbox/mapbox-gl-native-ios#501
iOS Fix scalebar ornament triggers unnecessary layoutSubviews mapbox/mapbox-gl-native-ios#507
iOS Fix issue: approximate Location indicator disappears at high zoom mapbox/mapbox-gl-native-ios#531
iOS Fix an issue where updating .followWithHeading prevents annotation's location updates mapbox/mapbox-gl-native-ios#580
Android Use weak references for Layer and Source API mapbox/mapbox-gl-native-android#516
Android Update http cancel log. mapbox/mapbox-gl-native-android#433
Android Smooth puck animation after changing style. mapbox/mapbox-gl-native-android#437
Android Add background image for GPS mode in IndicatorLocationLayerRender. mapbox/mapbox-gl-native-android#439
Android Set gps bearing immediately while changing to gps mode. #470 mapbox/mapbox-gl-native-android#470
Android Add http hook mapbox/mapbox-gl-native-android#472
Android Expose animation handling mapbox/mapbox-gl-native-android#491
Android [offline] remove world bounds validation when creating an offline region mapbox/mapbox-gl-native-android#495
Android Implement method to set padding when camera is tracking. mapbox/mapbox-gl-native-android#496
Android call setUserAnimationInProgress in LocationCameraController mapbox/mapbox-gl-native-android#501
Android Check isLocationTracking in the right place mapbox/mapbox-gl-native-android#504
Android Expose indicator position change listener mapbox/mapbox-gl-native-android#515
Android [testapp] fixup onSaveInstanceState usage mapbox/mapbox-gl-native-android#539
Android [style] add image array support mapbox/mapbox-gl-native-android#544
Android Crash when converting screencoordinate as part of moveBy mapbox/mapbox-gl-native-android#555
Android Fix Style not ready exception in locationcomponent mapbox/mapbox-gl-native-android#620
Android Fix pulse circle opacity calculate error mapbox/mapbox-gl-native-android#625

@nnhubbard
Copy link
Author

I created a PR for mapbox/mapbox-gl-native-ios#406:

#108

@nnhubbard
Copy link
Author

mapbox/mapbox-gl-native-ios#412 is already in mapLibre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants