-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS MGLMapView missing most commits since Sept 4, 2020 #105
Comments
The mapbox-gl-native was forked from d60fd30 - mgbl 1.6.0, mapbox-gl-native-ios from a139216 and mapbox-gl-native-android from 4c12fb2 mapbox-gl-native-ios and mapbox-gl-native-android depends on the core library (mapbox-gl-native) which was moved behind curtains by MapBox after May 7 2020 and code changes are no longer available for open-source community. So we took ios/android at the most recent version which is compatible (meaning it compiles and links) with the core library. Many commits in mapbox-gl-native-ios and mapbox-gl-native-android after this date have dependency on the core library and it is not possible simply cherry-pick them. From those with no dependency, we have cherry-picked some of them (please see the PR history) but some still remains to be cherry-picked. Here is a list of changes which could be potentially cherry-picked.
|
I created a PR for mapbox/mapbox-gl-native-ios#406: |
mapbox/mapbox-gl-native-ios#412 is already in |
For whatever reason, it seems that
mapLibre
was started using an older version ofmapbox-gl-native-ios
. I have compared the source and it seems that none of the commits since Sept. 4, 2020 have been added inmapLibre
. See:https://github.com/mapbox/mapbox-gl-native-ios/commits/main/platform/ios/src/MGLMapView.mm
Some of these are very important such as mapbox/mapbox-gl-native-ios@8689173#diff-2b12ba2cacef0e8c6a943690a80480a938985ff758d0b69cae5913c8d3cf9273 which clearly is still buggy in
mapLibre
because the fix has not been merged.Are there plans to merge all of the fixes to
MGLMapView
that are in themapbox-gl-native-ios
project?The text was updated successfully, but these errors were encountered: