Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include debug symbols with Android releases #2282

Closed
louwers opened this issue Apr 16, 2024 · 6 comments · Fixed by #2294
Closed

Include debug symbols with Android releases #2282

louwers opened this issue Apr 16, 2024 · 6 comments · Fixed by #2294
Assignees
Labels

Comments

@louwers
Copy link
Collaborator

louwers commented Apr 16, 2024

Include debug symbols with Android releases so developers can symbolicate crash logs, similar to how we are doing for iOS now.

@louwers louwers self-assigned this Apr 16, 2024
@louwers
Copy link
Collaborator Author

louwers commented Apr 17, 2024

I tried

    buildTypes {
        release {
            ndk {
                debugSymbolLevel 'full'
            }
        }

Doesn't seem to work.

@stefankarschti
Copy link
Collaborator

stefankarschti commented Apr 17, 2024

The libraries are built with symbols, then stripped.
I think it's controlled via the CMAKE_INSTALL_DO_STRIP variable. llvm-strip is called based on it.

@louwers
Copy link
Collaborator Author

louwers commented Apr 17, 2024

Cool, thanks for the hint.

You're right, that option is for apps.

@louwers
Copy link
Collaborator Author

louwers commented Apr 17, 2024

Sounds like CMake should include debug symbols when called via Gradle android/ndk#243

@louwers
Copy link
Collaborator Author

louwers commented Apr 17, 2024

I think they are here after a build:

% ls -lh MapLibreAndroid/build/intermediates/library_jni/drawableRelease/jni/arm64-v8a/libmaplibre.so 
-rw-r--r--@ 1 bart  staff   191M Apr 17 15:50 MapLibreAndroid/build/intermediates/library_jni/drawableRelease/jni/arm64-v8a/libmaplibre.so

There is no build/intermediates/cmake directory anymore.

@stefankarschti
Copy link
Collaborator

yes, the file size indicates there's contained debug information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants