Skip to content

Commit

Permalink
Bug 1607136 [wpt PR 21046] - Sort the registrations returned by getRe…
Browse files Browse the repository at this point in the history
…gistrations() by registration ID., a=testonly

Automatic update from web-platform-tests
Sort the registrations returned by getRegistrations() by registration ID. (#21046)

This patch makes the order of the registrations returned by
getRegistrations() be sorted by registration ID, which fixes the flaky
test of getregistrations.https.html. Related Github issue is in
w3c/ServiceWorker#1465

Bug: 925740
Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900
Reviewed-by: Makoto Shimazu <shimazuchromium.org>
Commit-Queue: Wei4 Wang <wei4.wangintel.com>
Cr-Commit-Position: refs/heads/master{#732749}

Co-authored-by: WangW_intel <54053982+wangw-1991users.noreply.github.com>

--

wpt-commits: 3b8990ef1b99135ad02f13b3389049921054c88f
wpt-pr: 21046

UltraBlame original commit: 3cdd21c5e484de85c344fe475dbeadb697bf886c
  • Loading branch information
marco-c committed Jan 28, 2020
1 parent 54ad6e5 commit 4076a77
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,19 @@
promise_test(async t => {
const scope1 = 'resources/scope/getregistrations/scope1';
const scope2 = 'resources/scope/getregistrations/scope2';
const scope3 = 'resources/scope/getregistrations/scope12';

const script = 'resources/empty-worker.js';
t.add_cleanup(() => service_worker_unregister(t, scope1));
t.add_cleanup(() => service_worker_unregister(t, scope2));
t.add_cleanup(() => service_worker_unregister(t, scope3));

const registrations = [
await service_worker_unregister_and_register(t, script, scope1),
await service_worker_unregister_and_register(t, script, scope2)
await service_worker_unregister_and_register(t, script, scope2),
await service_worker_unregister_and_register(t, script, scope3),
];

const value = await navigator.serviceWorker.getRegistrations();
assert_array_equals(value, registrations);
}, 'Register multiple times then getRegistrations');
Expand Down

0 comments on commit 4076a77

Please sign in to comment.