Skip to content

Commit

Permalink
Bug 1919939 [wpt PR 48213] - [Partitioned Popins] Popin-Policy Respon…
Browse files Browse the repository at this point in the history
…se Header (Default none), a=testonly

Automatic update from web-platform-tests
[Partitioned Popins] Popin-Policy Response Header (Default none)

Every top-frame response for a popin must include a Popin-Policy header
that permits the popin's opener's top-frame-origin. This is to ensure
popins cannot be opened in a partitioned context other than the one they
are designed to.

This CL requires the header to exist and permit access, whereas before
omitting the header would permit access.

Explainer: https://explainers-by-googlers.github.io/partitioned-popins/
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/

Bug: 340606651
Change-Id: I4577cefe3687c1cf0501a4c195161f1335d8023b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5865610
Reviewed-by: Dana Fried <dfriedchromium.org>
Auto-Submit: Ari Chivukula <arichivchromium.org>
Commit-Queue: Rakina Zata Amni <rakinachromium.org>
Reviewed-by: Rakina Zata Amni <rakinachromium.org>
Cr-Commit-Position: refs/heads/main{#1356212}

--

wpt-commits: 14686909771afddb61df9d8fc9a46eaeabb8df76
wpt-pr: 48213

UltraBlame original commit: 33271155043f49fe6e92fa125680f5c1f59c43e7
  • Loading branch information
marco-c committed Sep 25, 2024
1 parent ff181dd commit 3043ce4
Show file tree
Hide file tree
Showing 13 changed files with 187 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,8 @@
null
"

return
(
status
headers
=
[
(
"
Expand All @@ -279,6 +278,55 @@
"
)
]

if
request
.
headers
.
get
(
b
"
Sec
-
Popin
-
Context
"
)
=
=
b
"
partitioned
"
:

headers
.
append
(
(
b
'
Popin
-
Policy
'
b
"
partitioned
=
*
"
)
)

return
(
status
headers
f
"
"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,26 @@
"
)

headers
.
append
(
(
b
'
Popin
-
Policy
'
b
"
partitioned
=
*
"
)
)

cookies
=
readCookies
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,26 @@
"
)

headers
.
append
(
(
b
'
Popin
-
Policy
'
b
"
partitioned
=
*
"
)
)

message
=
request
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,26 @@
)
)

headers
.
append
(
(
b
'
Popin
-
Policy
'
b
"
partitioned
=
*
"
)
)

return
302
headers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,26 @@
"
)

headers
.
append
(
(
b
'
Popin
-
Policy
'
b
"
partitioned
=
*
"
)
)

message
=
request
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Popin
-
Policy
:
partitioned
=
*

0 comments on commit 3043ce4

Please sign in to comment.